alvarotrigo / alvarotrigo/fullPage.js

[Feature request] Modernize Slide Container using Flexbox

Ouverte
#4,742 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
enhancement
Langage dominant
JavaScript
Étoiles
35.4k
Forks
7.1k
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Currently, `fp-slide` and `fp-slidesContainer` rely on `float: left` and `display block`. I propose transitioning the slides to use `display: flex` flexbox.

One benefit is that on auto height section with slide, slides take up the height of max height slide and the rest would center horizontally.

```
.fp-slidesContainer {
height: 100%;
display: flex;
flex-direction: row;
...
}
```

That being said, I'm not sure of the corner cases and if this change would be backwards compatible though. I'm sure you've thought of this so wanted to get your opinion.

Thanks 🚀

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.