alunduil / alunduil/siren-json.hs
Codecov uploads authenticate by OIDC
- Vorherrschende Sprache
- Haskell
- Sterne
- 3
- Forks
- 1
- Ø Merge
- 5 Std. 46 Min.
- Gemergte PRs (30 T.)
- 63
Beschreibung
The `Upload to Codecov` step in `ci.yml` passes `token: ${{ secrets.CODECOV_TOKEN }}`. `alunduil-chezmoi` uploads with `use_oidc: true` instead, which leaves no upload token to store, rotate, or leak, and `alunduil/zfs-replicate#687` adopts the same. Converging the rest gives the repositories one Codecov pattern.
- [ ] Add `id-token: write` to the coverage job's `permissions` block, alongside the `contents: read` it already needs for checkout.
- [ ] Replace the action's `token:` input with `use_oidc: true`.
- [ ] Delete the `CODECOV_TOKEN` secret once no workflow reads it.
## Additional context
- Reference: the `shell-tests` job in `alunduil-chezmoi`'s `ci.yml`.
- A fork's pull request gets a read-only `GITHUB_TOKEN`, so `id-token: write` is unavailable there and the upload fails. Secrets are withheld from fork pull requests too, so the token this replaces fails the same way; worth confirming rather than assuming when the change lands.
- The secret itself lives wherever `alunduil-infrastructure` manages this repository, so the last item is a change there, not here.
Beitragsleitfaden
Rechercherichtung
Start with the coverage job in ci.yml and compare its Upload to Codecov step with the shell-tests job in alunduil-chezmoi. Check the workflow permissions and Codecov action inputs, then confirm fork pull requests behave as described. Done means this repository uses OIDC without CODECOV_TOKEN, and the secret is removed where alunduil-infrastructure manages it.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- github-actions
- Bereich
- ci-cd, security
- Issue-Typ
- Refactoring
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Aktiv
- Klarheit
- Klar beschrieben
- Anfängerfreundlichkeit
- 65/100