alttester / alttester/AltTester-Unity-SDK

Class WebsocketConnection's _create_connection function got err alttester.exceptions.ConnectionError: the JSON object must be str, bytes or bytearray, not NoneType

Open
#1,679 0 comments 1 reaction 0 assignees View on GitHub
bug no version
Dominant language
C#
Stars
121
Forks
24
PR merge metrics
No merged PRs in 30d

Description

Python 3
Unity 2022.3.39
AltTester® Unity SDK a 2.1.2
Android
macOS

### Summary

Class WebsocketConnection's _create_connection fuction got err alttester.exceptions.ConnectionError: the JSON object must be str, bytes or bytearray, not NoneType

### Steps to reproduce
When AltDriver connect to AltServer, WebsocketConnection called connect(). But when it call _create_connection with message like this
`++Rcv decoded: fin=1 opcode=1 data=b'{"messageId":null,"driverId":null,"commandName":"driverRegistered","isNotification":true}'`
The msg that _on_message received is `'{"messageId":null,"driverId":null,"commandName":"driverRegistered","isNotification":true}'`
After that, it parsed msg to json by `response = json.loads(message)`. And in `self._notification_handler.handle_notification(response)`, it continue parsed msg to json again by
`data = json.loads(message.get("data"))`. There's no data key on this json, so it cause ConnectionError when I call cls.alt_driver = AltDriver() with my Unity Android app

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.