alteryx / alteryx/featuretools

Typing info can be lost if user supplies a Woodwork initialized cutoff time dataframe

Ouverte
#1,667 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
7.7k
Forks
915
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

### Typing info can be lost if user supplies a Woodwork initialized cutoff time dataframe

Based on current code in the woodwork-integration branch of `calculate_feature_matrix.py` (https://github.com/alteryx/featuretools/blob/5b6b1ed0540d9f7435599b497417d35233146320/featuretools/computational_backends/calculate_feature_matrix.py#L164-L173), if a user supplies a cutoff time dataframe that has Woodwork initialized, the typing information set by the user can be lost.

We should update the code in calculate_feature_matrix to make sure user-supplied typing information is retained. This will also require updating code in the `_validate_cutoff_time` util function to make sure operations there do not cause typing information to be lost.

We should also add a test to make sure that user supplied typing information for pass-through columns on the cutoff time dataframe is retained to the feature matrix.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.