alteryx / alteryx/evalml

Revert changes to testing with new XGBoost release

Aperta
#3,331 0 commenti 0 reazioni 1 assegnatario Rivendicata da @fjlanasa Vedi su GitHub
good first issue tech debt testing
Lingua principale
Python
Stelle
850
Fork
96
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

In #3324 , we had to mark some tests as expected to fail since XGBoost was throwing a FutureWarning. The warning has been addressed in XGBoost, so we're just waiting for the [PR](https://github.com/dmlc/xgboost/pull/7595) merged to be released. This issue is discussed in the #3275 issue.

`evalml/tests/component_tests/test_xgboost_classifier.py` needs to have the `@pytest.mark.xfail` removed from the `test_xgboost_catch_warnings_label_encoder` test when XGBoost releases. EvalML will upgrade automatically when XGBoost releases, which should actually cause these tests to pass (and thus fail because of the xfail mark). Once the xfail is removed, this story is complete.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.