alphapapa / alphapapa/org-ql

org-ql-view-buffer applies agenda-filter-preset from previous (unrelated) agenda-view

Aberta
#121 1 comentário 1 reação 1 responsável Reivindicada por @alphapapa Ver no GitHub
bug
Linguagem predominante
Emacs Lisp
Estrelas
1.6k
Forks
120
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

Precondition:
I invoke a normal agenda-view (custom-command) with `org-agenda-tag-filter-preset` set.

bug:
any `org-ql-search` invocation applies the filter-preset from the normal agenda-view to its own buffer. the only way to get rid of the filter-preset is to invoke a normal agenda command that has no filter-preset and then call `org-ql-search`.

Hints to a possible fix:
if i alter the definition of `org-ql-view--display` so that `(org-agenda-prepare)` is called inside the view-buffer, the filter-preset does not carry over (sorry, no pull request):
> .....
> (with-current-buffer buffer
> (org-agenda-prepare) ;; call this here to prepare filter-settings for org-agenda-finalize later
> (use-local-map org-ql-view-map)
> ;; Prepare buffer, saving data for refreshing.
> (cl-loop for symbol in vars
> ....

From what i see, the call to `org-agenda-prepare` is necessary for `org-agenda-finalize` to do the right thing. I didnt check for any side-effects of this change though (first time digging this deep ;-)

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.