alphapapa / alphapapa/magit-todos

Idea: use (magit-get-upstream-ref) as ref commit

Abierto
#155 10 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement good first issue help wanted
Lenguaje dominante
Emacs Lisp
Estrellas
791
Forks
54
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

This is just an idea/suggestion. I see that magit-todos uses `(magit-main-branch)` to figure out (using `merge-base`) the revision to compare the HEAD against.

How about using `(magit-get-upstream-ref)` instead? I'm suggesting this, because people might not update their `main` branch for a long time, so it gets out of sync, and `merge-base` may find some very ancient revision, so we get a lot of entries in the TODO list.
On the other hand, `(magit-get-upstream-ref)` is usually more up-to-date, and it also more likely contains a more relevant revision to find the merge base.

What do you think?

I've been using this idea for a while, and it seems to work for me. If anyone interested, I use this snippet to achieve this:

```lisp
(defun my-magit-mode-hook ()
(let ((upstream (magit-get-upstream-ref)))
(when upstream
(setq magit-todos-branch-list-merge-base-ref upstream)))
(add-hook 'magit-mode-hook 'my-magit-mode-hook)
```

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.