alphagov / alphagov/notifications-python-client
MS Excel opens CSV files with incorrect encoding
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- Python
- Sterne
- 25
- Forks
- 23
- Ø Merge
- 3 T. 20 Std.
- Gemergte PRs (30 T.)
- 1
Beschreibung
This issue is only tangentially related to the notify service, but I wanted to flag it for discussion.
When CSV files are opened by MS Excel, Excel assumes that the file is ASCII encoded - unless a Byte Order Mark is specified in the first 3 octets of the file to denote the encoding. Further details can be found here: https://stackoverflow.com/a/155176
The result of Excel assuming the incorrect encoding is that special characters are rendered incorrectly to the user.
Excel's behaviour here is quite different to other standard spreadsheet applications. Calc on Linux and Numbers on Mac do a pretty good job of automatically detecting the encoding of the file.
I believe that this issue is a good one to discuss now that the Notify service supports CSV file uploads/downloads fully with the addition of is_csv to prepare_upload.
A very simple idea that I have is to call this behaviour out in the client docs (there's a new section on CSV uploads) - in order to get ahead of this issue for developers that are looking to send CSVs from their apps.
Example Code: CSV which is badly rendered in Excel:
import io
from notifications_python_client import prepare_upload
from notifications_python_client.notifications import NotificationsAPIClient
notifications_client = NotificationsAPIClient("XXX")
csv_contents = 'Büyükdere Cad,foo,bar'
buf = io.BytesIO(csv_contents.encode('utf-8'))
file_content = prepare_upload(buf, is_csv=True)
notifications_client.send_email_notification(
email_address='foobar@example.net',
template_id='XXX',
personalisation={
'link_to_file': file_content,
},
)
Example Code: CSV which is rendered correctly in Excel:
import codecs
import io
from notifications_python_client import prepare_upload
from notifications_python_client.notifications import NotificationsAPIClient
notifications_client = NotificationsAPIClient("XXX")
csv_contents = 'Büyükdere Cad,foo,bar'
buf = io.BytesIO(codecs.BOM_UTF8 + csv_contents.encode('utf-8'))
file_content = prepare_upload(buf, is_csv=True)
notifications_client.send_email_notification(
email_address='foobar@example.net',
template_id='XXX',
personalisation={
'link_to_file': file_content,
},
)
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne damit, den Abschnitt der Client-Dokumentation zu CSV-Uploads zu finden, und überprüfe, wie prepare_upload mit is_csv=True derzeit erklärt wird. Dokumentiere anhand der Beispiele in diesem Issue, dass Microsoft Excel UTF-8-CSV-Dateien ohne eine UTF-8-BOM möglicherweise falsch darstellt, und formuliere die Hinweise für Entwickler, die CSV-Dateien senden, eindeutig.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- python
- Bereich
- documentation
- Issue-Typ
- Dokumentation
- Schwierigkeit
- 2/5
- Geschätzter Aufwand
- 1-3 Stunden
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100