alpacahq / alpacahq/Alpaca-API

The API `PATCH/v2/orders/` incorrectly uses original qty and not updated qty if the order has a partial fill

Đang mở
#165 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
bug
Ngôn ngữ chính
Không có dữ liệu ngôn ngữ
Star
173
Fork
17
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

**Describe the bug**
When a sell order that was opened with qty=N is partially filled, and then gets replaced with a new price (using the `PATCH` API), the replaced order reflects the original qty N and NOT the unfilled qty. This results in the replaced partially filled orders ultimately filling the wrong total quantity or returning an error (because now, for a liquidating sell, it is trying to sell more than one has shares).

It appears that the replaced order gets created with qty = N (the original order qty). The correct behaviour would be to create the new order with with only the outstanding, unfilled shares, qty = N - partially_filled_qty.

This may also occur for a buy order but cannot confirm this.

**To Reproduce**
This is hard to reproduce because it only happens when replacing a partially filled order.

**Expected behavior**
The correct behaviour would be to create the new order with with only the outstanding, unfilled shares, qty = N - partially_filled_qty.

**Additional context**
There is a forum post explaining this behaviour in more detail.
https://forum.alpaca.markets/t/quantity-error-when-replacing-partially-filled-sell-order/4329

Hướng dẫn đóng góp

Chưa lập chỉ mục được hướng dẫn đóng góp cho kho mã nguồn này

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.