aloisdg / aloisdg/inkfathom

Reduce call to Scryfall

未关闭
#64 0 条评论 0 个 reaction 已指派 1 人 已被 @aloisdg 认领 在 GitHub 查看
help wanted must have performance
主要语言
JavaScript
星标
9
派生
7
PR 合并指标
30 天内没有已合并 PR

描述

When someone click on the search button, we grab the decklist. For each non-url line of the decklist, we extract the name, lang, set, etc. Then we do a call to the Scryfall's search API to get all matching answers. Finally we filter matching answers to get the one with a matching printed name. Then we call Scryfall once more to get the picture of the card.

When someone click on the switchButton of a given card, we call the Scryfall's API for a given card to get all the prints urls of the card. Then we load the next url one.

Two ideas:

* Is there a way to check from the search if there is more that one print of the card? We could avoid one call when there is no other prints available.
* Could we call another API to get directly the card by printed name, language and set with all available printings? Like this we could use this call instead of the to we are currently doing.

This may be a considerable alteration. We will wait for the end of #43 first.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。