aloisdg / aloisdg/inkfathom

Reduce call to Scryfall

Abierto
#64 0 comentarios 0 reacciones 1 asignado Reclamado por @aloisdg Ver en GitHub
help wanted must have performance
Lenguaje dominante
JavaScript
Estrellas
9
Forks
7
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

When someone click on the search button, we grab the decklist. For each non-url line of the decklist, we extract the name, lang, set, etc. Then we do a call to the Scryfall's search API to get all matching answers. Finally we filter matching answers to get the one with a matching printed name. Then we call Scryfall once more to get the picture of the card.

When someone click on the switchButton of a given card, we call the Scryfall's API for a given card to get all the prints urls of the card. Then we load the next url one.

Two ideas:

* Is there a way to check from the search if there is more that one print of the card? We could avoid one call when there is no other prints available.
* Could we call another API to get directly the card by printed name, language and set with all available printings? Like this we could use this call instead of the to we are currently doing.

This may be a considerable alteration. We will wait for the end of #43 first.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.