almin / almin/ddd-base

Entity/ValueObject: receive Props Instead of Identifier

Ouverte
#4 5 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Status: Proposal
Langage dominant
TypeScript
Étoiles
77
Forks
7
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

I've noticed that I often write a entity like following:

```ts
export class HatebuIdentifier extends Identifier {}
export interface HatebuProps {
readonly id: HatebuIdentifier;
readonly bookmark: Bookmark;
}

export class Hatebu extends Entity implements HatebuProps {
readonly bookmark: Bookmark;

constructor(args: HatebuProps) {
super(args.id);
this.bookmark = args.bookmark;
}

get name() {
return this.id.toValue();
}

addBookmarkItems(bookmarkItems: BookmarkItem[]) {
return new Hatebu({
...(this as HatebuProps),
bookmark: this.bookmark.addBookmarkItems(bookmarkItems)
});
}

updateBookmarkItems(bookmarkItems: BookmarkItem[]) {
return new Hatebu({
...(this as HatebuProps),
bookmark: this.bookmark.updateBookmarkItems(bookmarkItems)
});
}
}
```

This `Hatebu` entity has id and Props type.
We can use `Props` type insteadof `Id`.
Becaseue, Alwasys `Props` includes `id`.

## Props

- We can realize mixin meaningful #5
- `Copyable` insterface just use `Props` type
- It is similar with React https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L287-L288

## Cons

- `id` is fixed name
- Always arguments is object

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.