allure-framework / allure-framework/allure-python

Attribute error in @allure.title when using @pytest.fixture(params=[...]

未关闭
#873 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
theme:pytest
主要语言
Python
星标
814
派生
260
PR 合并指标
30 天内没有已合并 PR

描述

@allure.title decorator doesn't correctly formats a title string when using a parametrized fixture and having that fixture skip a test or raise an error:

```
import pytest
import allure

class TestClass:
@pytest.fixture(params=[1, 2]) # <-- causes AttributeError: 'int' object has no attribute 'one'
# @pytest.fixture()
def params(self):
# will cause AttributeError in allure.title
# if this fixture is skipping tests
pytest.skip('skip')

# or raising an error
raise ValueError('aa')

class _Params:
"""some params every test needs"""
one = 1
two = 2

# but no error if it returns a value
return _Params()

@allure.title('should display "1" {params.one}')
def test_func(self, params): # <-- causes AttributeError: 'int' object has no attribute 'one'
assert params.one == 1
```
```
self = , field_name = 'params.one', args = (), kwargs = {'param_id': '2', 'params': 2}

def get_field(self, field_name, args, kwargs):
first, rest = _string.formatter_field_name_split(field_name)

obj = self.get_value(first, args, kwargs)

# loop through the rest of the field_name, doing
# getattr or getitem as needed
for is_attr, i in rest:
if is_attr:
> obj = getattr(obj, i)
^^^^^^^^^^^^^^^
E AttributeError: 'int' object has no attribute 'one'

/usr/lib64/python3.12/string.py:305: AttributeError
=================================================================== short test summary info ====================================================================
ERROR p.py::TestClass::test_func[1] - AttributeError: 'int' object has no attribute 'one'
ERROR p.py::TestClass::test_func[2] - AttributeError: 'int' object has no attribute 'one'
====================================================================== 2 errors in 0.14s =======================================================================
```

This is shadowing the real error or skip in the fixture and is similar to #670

```
allure-pytest==2.15.0
pytest==8.4.1
```

贡献指南

打开贡献指南

调研方向

从 traceback 中显示的 @allure.title 格式化路径和 allure_commons.utils.SafeFormatter.get_field 入手;将其与 #670 中描述的行为进行比较。复现参数化 fixture 的 skip 和错误情况,然后验证报告的是原始的 pytest skip 或 ValueError,而不是 AttributeError。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
testing
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。