alloy-rs / alloy-rs/ruint

`support/arbitrary`: We should use `rand` in tests, not `arbitrary`.

未关闭
#197 0 条评论 0 个 reaction 已指派 1 人 已被 @recmo 认领 在 GitHub 查看
to do tracker
主要语言
Rust
星标
225
派生
70
平均合并
16 小时 54 分钟
30 天内合并 PR
8

描述

*On 2022-10-28 @recmo wrote in [`49f6271`](https://github.com/recmo/uint/commit/49f6271d9967c55a71f588ed267387b57a285d43) “Merge pull request #195 from recmo/pow2”:*

We should use `rand` in tests, not `arbitrary`.

```rust

// TODO: Instead of uniform random sampling, we should use a distribution that
// exercises different scales more. Something like sum(±2ⁱ for random i). The
// reduction step can then remove terms or make them smaller.

// TODO: We should use `rand` in tests, not `arbitrary`.

impl<'a, const BITS: usize, const LIMBS: usize> Arbitrary<'a> for Uint {
fn arbitrary(u: &mut Unstructured<'a>) -> Result {
let mut limbs = [0; LIMBS];
if let Some((last, rest)) = limbs.split_last_mut() {

```
*From [`src/support/arbitrary.rs:11`](https://github.com/recmo/uint/blob/49f6271d9967c55a71f588ed267387b57a285d43/src/support/arbitrary.rs#L11)*

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。