alloy-rs / alloy-rs/ruint

`algorithms/div/small`: This implementation is off by one.

Open
#180 0 comments 0 reactions 1 assignee Claimed by @recmo View on GitHub
to do tracker
Dominant language
Rust
Stars
225
Forks
70
Avg merge
16h 54m
Merged PRs (30d)
8

Description

*On 2022-10-24 @recmo wrote in [`fb3aa20`](https://github.com/recmo/uint/commit/fb3aa200dea389e2d1b0a23981da48a77a08b738) “Merge pull request #172 from recmo/div2”:*

This implementation is off by one.

```rust
(q1, r)
};
(q1, r)
}

/// TODO: This implementation is off by one.
#[inline(always)]
#[must_use]
pub fn div_3x2_ref(n21: u128, n0: u64, d: u128) -> u64 {
debug_assert!(d >= (1 << 127));
debug_assert!(n21 < d);

```
*From [`src/algorithms/div/small.rs:202`](https://github.com/recmo/uint/blob/fb3aa200dea389e2d1b0a23981da48a77a08b738/src/algorithms/div/small.rs#L202)*

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.