alloy-rs / alloy-rs/alloy

[Feature] Seperate transactionbuilder trait into non generic part

Aperta
#2,620 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
blocked enhancement
Lingua principale
Rust
Stelle
1.3k
Fork
668
Merge medio
2g 1h
PR unite (30g)
29

Descrizione

### Component

rpc

### Describe the feature you would like

ref https://github.com/alloy-rs/op-alloy/pull/557

unifying the transactionrequest type is a bit problematic because this makes the transaction trait ambigious because it has two impls for two networks, leading to clunky api that requires fully qualified path.

ideally this trait is separated into two parts, one that just sets all the fields, and one that actually builds the transaction for that network.

however this would be a smol breaking change

fyi @yash-atreya for context

### Additional context

_No response_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.