alloy-rs / alloy-rs/alloy

[Feature] Seperate transactionbuilder trait into non generic part

Open
#2,620 1 comment 0 reactions 0 assignees View on GitHub
blocked enhancement
Dominant language
Rust
Stars
1.3k
Forks
668
Avg merge
2d 2h
Merged PRs (30d)
29

Description

### Component

rpc

### Describe the feature you would like

ref https://github.com/alloy-rs/op-alloy/pull/557

unifying the transactionrequest type is a bit problematic because this makes the transaction trait ambigious because it has two impls for two networks, leading to clunky api that requires fully qualified path.

ideally this trait is separated into two parts, one that just sets all the fields, and one that actually builds the transaction for that network.

however this would be a smol breaking change

fyi @yash-atreya for context

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.