alleyinteractive / alleyinteractive/wp-curate

Remove `supportsLevel` in post-title's `TagName` condition

未關閉
#449 0 則留言 0 個 reaction 已指派 1 人 已被 @goodguyry 認領 在 GitHub 檢視
主要語言
PHP
星號
11
分支
3
PR 合併指標
30 天內沒有已合併 PR

描述

### Description of the bug

Setting `supportsLevel: false` should only remove the dropdown. However, this condition forces a paragraph in the editor, but renders the default (`h3`) on the frontend. Ideally the attribute would only be used to conditionally render the heading selector.

https://github.com/alleyinteractive/wp-curate/blob/5a315bfcb8aa157da108b89df61e3e954565ccf8/blocks/post-title/edit.tsx#L58

### Steps To Reproduce

1. Add a `wp-curate/query` block
2. Switch to code view and add `{"supportsLevel":false}` to the `wp-curate/post-title` attributes
3. Exit the code editor
4. Observe the post title is a paragraph
5. Save and view the frontend
6. Observe the post title is an h3

### Additional Information

_No response_

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。