alleyinteractive / alleyinteractive/mantle-framework

Better testing for monorepo projects in isolation

Aberta
#817 1 comentário 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
PHP
Estrelas
28
Forks
7
Merge médio
2d 4h
PRs com merge (30d)
2

Descrição

### Description

https://github.com/alleyinteractive/mantle-framework/pull/816 arose because it referenced an interface from the types package within support. On a normal project, this is usually fine. But a monorepo like `mantle-framework` this resulted in an undefined class error:

> Class "Mantle\Types\Validator" not found

Example project that uses support and testkit but did not import the newer types package and failed because of this: https://github.com/alleyinteractive/wp-modified-date-control/pull/99

We need to figure out how we can test our subprojects in better isolation from one another. Perhaps there is a CI step that can check for cross-project references without being explicitly declared in the subproject's `composer.json`.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.