alleyinteractive / alleyinteractive/alley-scripts

SlotFill entrypoint template comment causes issue with common PHPCS rule

Abierto
#684 0 comentarios 0 reacciones 0 asignados Ver en GitHub
bug good first issue
Lenguaje dominante
TypeScript
Estrellas
10
Forks
3
Merge medio
4 d 22 h
PR fusionados (30 d)
2

Descripción

### Description of the bug

Following the basic setup steps for `npm run create-slotfill` will create a PHPCS violation against a commonly used rule: `Generic.Commenting.DocComment.ShortNotCapital`. A simple fix here could be to simply change the comment text.

See: https://github.com/alleyinteractive/alley-scripts/blob/main/packages/create-entry/templates/slotfill/index.php.mustache#L4

### Steps To Reproduce

1. `npm run create-slotfill`
2. name the slotfill slug anything starting with a lower-case letter
3. follow the rest of the setup prompts and create the slotfill files.
4. run PHPCS the generated PHP file in `/entries//index.php` (the ruleset must include `Generic.Commenting.DocComment.ShortNotCapital`)

### Additional Information

_No response_

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.