allenai / allenai/molmo

Image resizing and point coordinates

未關閉
#52 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Python
星號
933
分支
96
PR 合併指標
30 天內沒有已合併 PR

描述

Hi!

I am super interested in the pointing functionality but haven't seen anyone asked about this detail:

**When you resize the images in the preprocessor, do you also rescale the "_point coordinates_" accordingly?** It feels to be the right way but from the fact that the code handles the formatter before resizing the images:
first do data formatting
https://github.com/allenai/molmo/blob/793fa387edfd6fd0f5b21eb8e0a7620a1f3799e1/olmo/data/model_preprocessor.py#L836
then call multimodal processor
https://github.com/allenai/molmo/blob/793fa387edfd6fd0f5b21eb8e0a7620a1f3799e1/olmo/data/model_preprocessor.py#L841

(I might certainly miss some details!!), looks like the points' coordinates are kept to its original value and serialized into texts.
Can you share some more insights on this? Thanks a lot!

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。