allenai / allenai/cached_path

Make `extract_archive=True` the default

Đang mở
#214 3 bình luận 0 reaction 0 người được giao Xem trên GitHub
Feature request
Ngôn ngữ chính
Python
Star
47
Fork
22
Chỉ số merge pull request
Không có pull request nào được merge trong 30 ngày

Mô tả

**Is your feature request related to a problem? Please describe.**
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

`cached_path` is great because I can take a file path or a URL, seamlessly. However, if the file referenced by a URL is a file inside an archive file (e.g., a ZIP file), I have to pass `extract_archive=True`. I have to do this for every function call that may potentially receive a file inside another one, which hurts the "seamlessly" aspect.

At the same time, `extract_archive=True` because the same as if it was `False` if the URL has no exclamation sign ("!") in it.

**Describe the solution you'd like**

I believe we should switch to `extract_archive=True` by default, as it behaves to automatically detect if it's an archive or not. URLs won't have this symbol to indicate anything else, as it'd otherwise be URL-encoded ("%21").

I have used this behavior for a while on my own fork, and it works without any issues.

**Describe alternatives you've considered**

I haven't considered other alternatives.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.