allenai / allenai/allentune

Expecting stdout.log rather than out.log

Open
#17 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
141
Forks
13
PR merge metrics
No merged PRs in 30d

Description

I'm using `allentune` with `allennlp==2.4.0`. First it would be nice if the explicit requirement on `allennlp==1.0.0` was removed from `setup.py`, that way at least there's a chance that users can continue to install the library as other dependencies move on, you can always set it to `allennlp>=1.0.0` and users can choose to install 1.0.0 before `allentune` if they want to replicate the original configuration.

https://github.com/allenai/allentune/blob/437e98c02bd746f43f0a128f9d096cce85441ed7/setup.py#L38

I had to leave `ray==0.8.6` due to a dependency class.

I'm not sure if it's a result of running on a later version of `allennlp` or not, the `search` command worked fine. However `report` errored. On further investigation the report script was looking for a `stdout.log` file, the file was actually called `out.log`

It was a simple fix to update, I simply changed the line below:

https://github.com/allenai/allentune/blob/437e98c02bd746f43f0a128f9d096cce85441ed7/allentune/commands/report.py#L50

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.