allenai / allenai/allentune

Expecting stdout.log rather than out.log

Abierto
#17 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
141
Forks
13
Métricas de merge de PR
Métricas de PR pendientes

Descripción

I'm using `allentune` with `allennlp==2.4.0`. First it would be nice if the explicit requirement on `allennlp==1.0.0` was removed from `setup.py`, that way at least there's a chance that users can continue to install the library as other dependencies move on, you can always set it to `allennlp>=1.0.0` and users can choose to install 1.0.0 before `allentune` if they want to replicate the original configuration.

https://github.com/allenai/allentune/blob/437e98c02bd746f43f0a128f9d096cce85441ed7/setup.py#L38

I had to leave `ray==0.8.6` due to a dependency class.

I'm not sure if it's a result of running on a later version of `allennlp` or not, the `search` command worked fine. However `report` errored. On further investigation the report script was looking for a `stdout.log` file, the file was actually called `out.log`

It was a simple fix to update, I simply changed the line below:

https://github.com/allenai/allentune/blob/437e98c02bd746f43f0a128f9d096cce85441ed7/allentune/commands/report.py#L50

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.