allenai / allenai/ai2thor

Bugs in the idea of get_shortest_path_to_object(object_id)

Offen
#615 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
bug
Vorherrschende Sprache
C#
Sterne
1.8k
Forks
297
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

`get_shortest_path_to_object` with `object_id` is prone to breaking.

It states: For multiple objects of the same type e.g. Bottle, there is a version of the method which takes a specific object id.

```python
get_shortest_path_to_object(
controller,
object_id,
initial_position
)
```
since `object_id`'s are generated at runtime and often change slightly due to the non-deterministic physics that resolves each object's initialized position and floating point error.

This is also related to the request of exposing the prefab, where perhaps using the prefabs name is a better indexed literal constant instead of the objectId. (Of course, if there's multiple of the same prefab, that's still a problem.)

https://ai2thor.allenai.org/robothor/documentation/#shortest-path

---

Edit: this problem might be alleviated with a single shortest path call, where one can simply query the metadata for the correct objectId ahead of time. (This assumes the scene does not get reset.) But, in the case where you're passing in a set of objectId's to compute the batched shortest paths, this bug would still occur.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.