allenai / allenai/ai2thor

Bugs in the idea of get_shortest_path_to_object(object_id)

Open
#615 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
C#
Stars
1.8k
Forks
296
PR merge metrics
No merged PRs in 30d

Description

`get_shortest_path_to_object` with `object_id` is prone to breaking.

It states: For multiple objects of the same type e.g. Bottle, there is a version of the method which takes a specific object id.

```python
get_shortest_path_to_object(
controller,
object_id,
initial_position
)
```
since `object_id`'s are generated at runtime and often change slightly due to the non-deterministic physics that resolves each object's initialized position and floating point error.

This is also related to the request of exposing the prefab, where perhaps using the prefabs name is a better indexed literal constant instead of the objectId. (Of course, if there's multiple of the same prefab, that's still a problem.)

https://ai2thor.allenai.org/robothor/documentation/#shortest-path

---

Edit: this problem might be alleviated with a single shortest path call, where one can simply query the metadata for the correct objectId ahead of time. (This assumes the scene does not get reset.) But, in the case where you're passing in a set of objectId's to compute the batched shortest paths, this bug would still occur.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.