allenai / allenai/ScienceWorld

Optional goals are marked too early

Open
#17 0 comments 0 reactions 0 assignees View on GitHub
To be confirmed
Dominant language
Scala
Stars
391
Forks
42
PR merge metrics
No merged PRs in 30d

Description

I noticed the issue in `task-7-identify-life-stages-1-var0`, but others might be affected. I have a modified version of the web server example that prints out SW's goals. I attached a PDF printout of my browser to illustrate the bug.

* At Move 8, `GoalStayInLocation Stay in goal location for 10 steps`, `GoalStayInLocation Stay in goal location for 20 steps`, and `GoalStayInLocation Stay in goal location for 30 steps` are all `false`
* At Move 9 I issue the `wait` command and SW confirms waiting for 10 iterations.
* After `wait` (still at Move 9) the goals `GoalStayInLocation Stay in goal location for 10 steps`, `GoalStayInLocation Stay in goal location for 20 steps`, and `GoalStayInLocation Stay in goal location for 30 steps` are all `true` when only the first one should be `true`.

[time_goal_bug.pdf](https://github.com/allenai/ScienceWorld/files/9270144/time_goal_bug.pdf)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.