allegro / allegro/axion-release-plugin

`VersionConfig#releaseBranchPattern` doesn't update release branch pattern when used together with `incrementMinorIfNotOnRelease` incrementer

未關閉
#396 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug hacktoberfest help wanted
主要語言
Groovy
星號
641
分支
165
平均合併
49 分鐘
30 天內合併 PR
9

描述

Originally reported in: https://github.com/allegro/axion-release-plugin/issues/391#issuecomment-811393047

Given following config
```groovy
scmVersion {

versionIncrementer = PredefinedVersionIncrementer.versionIncrementerFor('incrementMinorIfNotOnRelease')
releaseBranchPattern = Pattern.compile('^random(/.*)?$')
}
```

and according to the documentation

>If incrementMinorIfNotOnRelease rule is activated then the property ``releaseBranchPattern`` is used to match the release
branch. By default it's set to 'v/.+'.

the plugin should increment patch version when on `random/x.y.z` branch, minor in all other cases.

It seems like is was broken since at least `1.11.0`.

### Sample repository
https://github.com/mateuszkwiecinski/axion_playground

### Expected result
when on `release/7.8.9` the plugin returns `7.9.0-SNAPSHOT` version
when on `master` the plugin reports `7.9.0-SNAPSHOT`
when on `random/7.8.9` the plugin prints `7.8.10-SNAPSHOT`
when on `v/7.8.9` the plugin prints `7.9.0-SNAPSHOT`

### Actual result
(tested on `1.13.1`)
when on `release/7.8.9` the plugin returns `7.9.0-SNAPSHOT` version
when on `master` the plugin reports `7.9.0-SNAPSHOT`
when on `random/7.8.9` the plugin prints `7.9.0-SNAPSHOT` ❌
when on `v/7.8.9` the plugin prints `7.8.10-SNAPSHOT`❌

### Known workaround
use `versionIncrementer` overload
```groovy
scmVersion {
versionIncrementer 'incrementMinorIfNotOnRelease', [releaseBranchPattern: 'random/.*']
}
```

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。