allegro / allegro/akubra

Don't compile with current version of golint

Open
#105 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
88
Forks
9
PR merge metrics
No merged PRs in 30d

Description

```gometalinter ./... \
--disable=gotype \
--disable=dupl \
--deadline=600s \
--enable=goimports \
--vendor \
--fast
config/config.go:141::warning: Potential file inclusion via variable,MEDIUM,HIGH (gosec)
config/config.go:174::warning: Errors unhandled.,LOW,HIGH (gosec)
config/config.go:175::warning: Errors unhandled.,LOW,HIGH (gosec)
config/config.go:212::warning: Errors unhandled.,LOW,HIGH (gosec)
config/config.go:220::warning: Errors unhandled.,LOW,HIGH (gosec)
config/config.go:229::warning: Errors unhandled.,LOW,HIGH (gosec)
log/sql/connection.go:86::warning: Errors unhandled.,LOW,HIGH (gosec)
Makefile:8: recipe for target 'lint' failed
make: *** [lint] Error 1
```
It help to add --disable=gosec to gometalinter parameters.

Example dockerfile to try to build:
```
FROM golang:1.11
ENV GOROOT /usr/local/go/
RUN mkdir -p /go/src/github.com/allegro/
RUN cd /go/src/github.com/allegro/ && git clone https://github.com/allegro/akubra.git
WORKDIR /go/src/github.com/allegro/akubra
RUN make build
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.