algorand / algorand/js-algorand-sdk

Convert all client responses to typed objects

Aberta
#771 2 comentários 1 reação 1 responsável Reivindicada por @Eric-Warehime Ver no GitHub
new-feature-request Team Lamprey
Linguagem predominante
TypeScript
Estrelas
297
Forks
214
Merge médio
1h 3min
PRs com merge (30d)
3

Descrição

## Problem

Responses from the client are not automatically converted into the defined model types (for all endpoints).

We've done this for some endpoints (see https://github.com/algorand/js-algorand-sdk/blob/a89046acaf9502f496fca9d781bf33047c969c01/src/client/v2/algod/getApplicationBoxes.ts#L57-L60), but other endpoints, in order to avoid backwards incompatible changes, do not implement this (see https://github.com/algorand/js-algorand-sdk/blob/a89046acaf9502f496fca9d781bf33047c969c01/src/client/v2/algod/getApplicationByID.ts for example).

## Solution

Implement the `response.from_obj_for_encoding(body)` for all endpoints which return structured data.

## Dependencies

N/A

## Urgency

We should group this with any other breaking changes being made in the next major version bump.

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.