algorand / algorand/js-algorand-sdk

Convert all client responses to typed objects

Aperta
#771 2 commenti 1 reazione 1 assegnatario Rivendicata da @Eric-Warehime Vedi su GitHub
new-feature-request Team Lamprey
Lingua principale
TypeScript
Stelle
297
Fork
214
Merge medio
1h 3m
PR unite (30g)
3

Descrizione

## Problem

Responses from the client are not automatically converted into the defined model types (for all endpoints).

We've done this for some endpoints (see https://github.com/algorand/js-algorand-sdk/blob/a89046acaf9502f496fca9d781bf33047c969c01/src/client/v2/algod/getApplicationBoxes.ts#L57-L60), but other endpoints, in order to avoid backwards incompatible changes, do not implement this (see https://github.com/algorand/js-algorand-sdk/blob/a89046acaf9502f496fca9d781bf33047c969c01/src/client/v2/algod/getApplicationByID.ts for example).

## Solution

Implement the `response.from_obj_for_encoding(body)` for all endpoints which return structured data.

## Dependencies

N/A

## Urgency

We should group this with any other breaking changes being made in the next major version bump.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.