algorand / algorand/java-algorand-sdk

`Transaction.equals` does not check all fields

Open
#403 0 comments 0 reactions 0 assignees View on GitHub
bug good first issue Team Lamprey
Dominant language
Java
Stars
73
Forks
71
Avg merge
41m
Merged PRs (30d)
2

Description

## Problem

The `Transaction.equals` method checks for equality between two `Transaction` objects. Currently, many fields from the two transactions are checked, but there is a large number of fields (mostly app call transaction ones) which are **NOT** currently being checked.

## Scope

The `Transaction.equals` method _should_ check equality by checking all possible transaction fields.

Consider also an automated test which can somehow verify that each transaction field is checked by the `equals` method.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.