algorand / algorand/java-algorand-sdk

Correctness: Overriding equals, but not hashCode

未關閉
#344 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
bug good first issue Team Lamprey
主要語言
Java
星號
73
分支
71
平均合併
41 分鐘
30 天內合併 PR
2

描述

### Subject of the issue

While working on https://github.com/algorand/java-algorand-sdk/pull/340#discussion_r912043589, I observed numerous instances where `equals` is overwritten, but not `hashCode`.

The status quo breaks `hashCode`'s contract as discussed in https://stackoverflow.com/questions/2265503/why-do-i-need-to-override-the-equals-and-hashcode-methods-in-java.

### Your environment

N/A

### Steps to reproduce
N/A

### Expected behaviour

There's at least 2 solutions:
* Immediately - Consistently override `hashCode` and `equals`. Prefer using an IDE-generated implementation.
* Longer term - Upgrade to >= JDK 16 and replace class definitions with records (https://docs.oracle.com/en/java/javase/16/language/records.html). Among other benefits, records obviate the need to manage `equals` and `hashCode` implementations.

### Actual behaviour
N/A

# Acceptance Criteria
1. Updating hand written code to implement both functions.
2. Update code generator to generate hashCode along with equals, then regenerate the code.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。