algorand / algorand/go-algorand
PR template asks to run make generate but it isn't possible for it to currently execute.
- Langage dominant
- Go
- Étoiles
- 1.4k
- Forks
- 537
- Merge moyen
- 1 j 7 h
- PR mergées (30 j)
- 18
Description
### Subject of the issue
The PR template mentions running make sanity as well as make generate.
make generate can't be run for the code that's currently committed. It issues errors for swagger, and also hard fails due to missing files.
data/account.go contains a generate command referencing a 'part.sql' file that was removed from the repository. No history of the file exists in fact.
### Steps to reproduce
Run make generate....
### Expected behaviour
It works. 😀
### Actual behaviour
```
2020/04/19 22:26:50
The swagger spec at "../swagger.json" is valid against swagger specification 2.0
2020/04/19 22:26:50
The swagger spec at "../swagger.json" showed up some valid but possibly unwanted constructs.
2020/04/19 22:26:50 See warnings below:
2020/04/19 22:26:50 - WARNING: response "#/responses/RawBlockResponse" is not used anywhere
The swagger spec at "./swagger.json" is invalid against swagger specification 2.0.
See errors below:
- some references could not be resolved in spec. First found: object has no key "ListMultisigResponse"
daemon/kmd/api/api.go:62: running "swagger": exit status 1
panic: open part.sql: no such file or directory
```
There is the swagger error, but most importantly, the missing 'part.sql' file referenced by this line:
//go:generate dbgen -i part.sql -p account -n part -o partInstall.go
in data/account/account.go
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.