algorand / algorand/go-algorand
Rework TestResolverWithCloudflareDNSResolution to avoid 3rd party callouts
Aperta
Team Carbon-11
- Lingua principale
- Go
- Stelle
- 1.4k
- Fork
- 537
- Merge medio
- 1g 7h
- PR unite (30g)
- 18
Descrizione
## Problem
`TestResolverWithCloudflareDNSResolution` makes callouts to Cloudflare. As discussed in prior PRs (e.g. https://github.com/algorand/go-algorand/pull/4941, https://github.com/algorand/go-algorand/pull/4965), we've encountered instability when CircleCI blocks outgoing calls.
It's problematic for unit tests to fail due to a 3rd party callout. The story requests reworking the test to remove the 3rd party callout (e.g. setup locally running DNS stand-in on port 53).
## Solution
- Potential Solution: Do not run DNS tests on PR tests, but rather on nightly tests
## Dependencies
## Urgency
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.