algorand / algorand/go-algorand

scripts: remove dependency on AWS_ environment variables

未关闭
#4,593 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
new-feature-request Team Hyper Flow
主要语言
Go
星标
1.4k
派生
537
平均合并
1 天 7 小时
30 天内合并 PR
18

描述

## Problem

some scripts will fail if `AWS_ACCESS_KEY_ID` or `AWS_SECRET_ACCESS_KEY` are not set.

for example

https://github.com/algorand/go-algorand/blob/d3c10f41f2ac3e2bf84d8ddfd134c1cfba3d0908/scripts/create_and_deploy_private_version.sh#L24-L27

https://github.com/algorand/go-algorand/blob/d3c10f41f2ac3e2bf84d8ddfd134c1cfba3d0908/scripts/create_and_deploy_recipe.sh#L25-L28

https://github.com/algorand/go-algorand/blob/d3c10f41f2ac3e2bf84d8ddfd134c1cfba3d0908/scripts/deploy_linux_version.sh#L43-L46

this limits one's ability to use more secure means of authenticating with AWS, e.g. EC2 metadata or IRSA.

## Solution

remove these checks. if it's still desired to have an AWS check, use `aws sts get-caller-identity` to determine if the shell is configured properly for AWS communication. this is appropriate because utlimtaely the scrips use the aws cli to communicate with S3.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。