algorand / algorand/go-algorand

Move eval constants into consensus and normalize

Ouverte
#3,746 7 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
new-feature-request Team Scytale
Langage dominant
Go
Étoiles
1.4k
Forks
537
Merge moyen
1 j 7 h
PR mergées (30 j)
18

Description

I had an unwelcome discovery today that there are some constants in the TEAL evaluator that aren't in consensus.go and others that have different values...

For example MaxLogSize isn't in it:
https://github.com/algorand/go-algorand/blob/master/data/transactions/logic/eval.go#L59

And MaxLogCalls is 32 in eval.go but in consensus.go is something really really big --- https://github.com/algorand/go-algorand/blob/master/config/consensus.go#L536

I know it takes a long time to add stuff to consensus parameters, but please put this on your list

Also, I'd like MaxLogSize to be a bit bigger, like bigger than MaxAppTotalArgLen

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.