algorand / algorand/go-algorand
Move eval constants into consensus and normalize
Đang mở
new-feature-request
Team Scytale
- Ngôn ngữ chính
- Go
- Star
- 1.4k
- Fork
- 537
- Merge trung bình
- 1 ngày 6 giờ
- Pull request đã merge (30 ngày)
- 17
Mô tả
I had an unwelcome discovery today that there are some constants in the TEAL evaluator that aren't in consensus.go and others that have different values...
For example MaxLogSize isn't in it:
https://github.com/algorand/go-algorand/blob/master/data/transactions/logic/eval.go#L59
And MaxLogCalls is 32 in eval.go but in consensus.go is something really really big --- https://github.com/algorand/go-algorand/blob/master/config/consensus.go#L536
I know it takes a long time to add stuff to consensus parameters, but please put this on your list
Also, I'd like MaxLogSize to be a bit bigger, like bigger than MaxAppTotalArgLen
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.