algorand / algorand/go-algorand-sdk

Conditional Client API token

Open
#653 0 comments 0 reactions 0 assignees View on GitHub
new-feature-request
Dominant language
Go
Stars
189
Forks
107
Avg merge
1d 9h
Merged PRs (30d)
3

Description

## Problem
By default, Algorand public APIs require an algod_token to be consumed. However, it also allows the option to disable API authentication. When API auth is disabled, the request to the algod node can't be done since the algod token is always required by the client in go-algorand-sdk

## Solution
A potential solution could be to include a condition on [client.apiToken](https://github.com/algorand/go-algorand-sdk/blob/a55d63f27569304696d4e49971e3342e0b6bed21/client/v2/common/common.go#L157)
```
if len(client.apiToken) > 0 {
req.Header.Set(client.apiHeader, client.apiToken)
}
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.