algolia / algolia/algoliasearch-client-python
runtime error trying to deserialise non json responses
Open
Bug
- Dominant language
- Python
- Stars
- 207
- Forks
- 63
- PR merge metrics
- No merged PRs in 30d
Description
The Python API client throws a runtime exception while attempting to desialize a non json response. Note that, as described on the JavaScript API Client, we should **NOT** deserialise responses on those cases:
```js
isTimedOut || isNetworkError(response) || (~~(status / 100) !== 2 && ~~(status / 100) !== 4)
```
Source: https://github.com/algolia/algoliasearch-client-javascript/blob/master/packages/transporter/src/concerns/retryDecision.ts#L12.
Solution: Create a pull request that ensures that no `response.json()` is performed on the cases mentioned above.
Contributor guide
Assessment
This issue has not been assessed yet.