alexcrack / alexcrack/angular-ui-notification

protractor tests : using $interval instead of $timeout for notify duration management

Aperta
#78 3 commenti 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
529
Fork
164
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

I use this module in my application to display notifications that disappear after a few seconds, and I write protractor e2e tests : the notifications are not testable.
This issue comes from the $timeout service to manage notification duration : protractor waits for $timeouts (and $http) before to run actions and expectations. So notification with duration can't be tested as they disappear before protractor tests them.
I think you are aware of this since you used the ignoreSynchronization parameter in your own protractor tests. But this is not a solution, we should still be able to let protractor wait for the end of $http requests.
In documentation (https://github.com/angular/protractor/blob/master/docs/timeouts.md), protractor team advises to replace $timeout services by $interval services to this kind of issue.

Have you considered using $interval instead of $timeout ?

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.