alexcrack / alexcrack/angular-ui-notification

Top plus height position calculation seems wrong

Open
#143 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
529
Forks
164
PR merge metrics
No merged PRs in 30d

Description

When I have multiple notifications, that exceed the visible window height, the last one that appears in the column, before moving to the next column is partly cut. This is the original code:
```
if ((top + elHeight) > window.innerHeight) {
position = startTop;
k ++;
j = 0;
}
```
To fix I changed the query to this:
`if ((position + elHeight) > window.innerHeight) {`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.