alexcrack / alexcrack/angular-ui-notification

Change name of provider

Open
#131 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
529
Forks
164
PR merge metrics
No merged PRs in 30d

Description

This provider has name 'Notification' same name of [Web API Notification](https://developer.mozilla.org/en-US/docs/Web/API/notification) implements on all browsers.
You can use angularjs safe dependency injection to avoid this problem, but i believe this is bad practice that can generate conflicts.

In my project i override for 'angularNotification' and use safe dependency injection to tackle this problem

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.