alex / alex/pyvcs

git author is the committer

Open
#14 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
128
Forks
11
PR merge metrics
No merged PRs in 30d

Description

In git.py you're doing:

```
return Commit(commit.id, commit.committer,
datetime.fromtimestamp(commit.commit_time), commit.message, files,
lambda: generate_unified_diff(self, files, parent, commit.id))
```

But this sets the author of the commit to the committer, which isn't always the case. It should be:

```
return Commit(commit.id, commit.author,
datetime.fromtimestamp(commit.commit_time), commit.message, files,
lambda: generate_unified_diff(self, files, parent, commit.id))
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.