alegrey91 / alegrey91/harpoon

Refactoring idea: Run method

未關閉
#63 0 則留言 1 個 reaction 已指派 0 人 在 GitHub 檢視
enhancement help wanted
主要語言
C
星號
178
分支
12
PR 合併指標
30 天內沒有已合併 PR

描述

Run method use channels for errors and outputs, but also use a fmt.Fprintf(os.Stderr

We could check what could be done to simplify things. Ideas such as:

- check of the method signature shouldn't be updated to return an error. Handling error with printing is strange to me,it should be moved to higher level.
- check if other errors currently send to outputCh or errCh shouldn't also be refactored

_Originally posted by @ccoVeille in https://github.com/alegrey91/harpoon/pull/60#discussion_r1894676098_

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。