alecthomas / alecthomas/participle

possible bug in tag syntax

Abierto
#249 4 comentarios 1 reacción 0 asignados Ver en GitHub
Lenguaje dominante
Go
Estrellas
3.9k
Forks
213
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Hello,

it seems there is a difference between the "raw" and "parse" tag syntax? The following repro shows what I stumbled upon.

```go
package tagsyntax

import (
"testing"

"github.com/alecthomas/assert/v2"
"github.com/alecthomas/participle/v2"
)

type GoodAST struct {
Key string `parser:"@Ident '='"`
BlankLines []string `"\n"`
}

type BadAST struct {
Key string `parser:"@Ident '='"`
// Same as field in GoodAST, as explained in https://github.com/alecthomas/participle#tag-syntax
BlankLines []string `parser:"'\n'"`
}

func TestLiteralNotTerminatedGood(t *testing.T) {
_, err := participle.Build(&GoodAST{})

assert.NoError(t, err)
}

func TestLiteralNotTerminatedBad(t *testing.T) {
_, err := participle.Build(&BadAST{})

// The error is:
//
// Key: :1:2: literal not terminated
//
// which is confusing because it refers to the previous field in the struct (Key)
// and unclear?
assert.NoError(t, err)
}
```

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.