alecthomas / alecthomas/entityx

Allow for move-only components.

Open
#208 1 comment 3 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
2.3k
Forks
301
PR merge metrics
No merged PRs in 30d

Description

Right now, trying to do `e.assign(...)` for some C that has a deleted copy constructor will cause a substitution error when instantiating ComponentHelper::copy_component_to, even if that method is never called as the vtable still must be constructed. It would be nice to have proper support for move-only components as well.

A simple solution is to use SFINAE on ComponentHelper:
```
template
+class ComponentHelper>>: public BaseComponentHelper { ... }
```
and to not actually copy in copy_component_to, but that delays any errors trying to copy until runtime. That is suboptimal, and there should be a much more elegant solution.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.