alanshaw / alanshaw/david-www

Badge colour always green when all dependencies pinned

Ouverte
#48 2 commentaires 2 réactions 0 personnes assignées Voir sur GitHub
bug help wanted question
Langage dominant
JavaScript
Étoiles
720
Forks
125
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

At the moment David considers tags, absolute versions (i.e. not semver ranges) and URLs as pinned dependencies. The idea being that the author wants to use a specific version because higher versions don't contain the same functionality (the author doesn't have a choice not to use the dependency at that version) or because it is a custom build of the module (for a URL dependency) or for some other reason. Pinned dependencies don't normally count towards your David badge, but when an author has pinned _all_ dependencies to specific versions the reasoning behind not counting pinned dependencies towards your badge is incorrect, since if all dependencies are pinned the badge will _always_ be green.

I propose that when _all_ dependencies are pinned, absolute versions _should_ affect the David badge colour.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.