alanshaw / alanshaw/david-www

Badge colour always green when all dependencies pinned

Open
#48 2 comments 2 reactions 0 assignees View on GitHub
bug help wanted question
Dominant language
JavaScript
Stars
720
Forks
125
PR merge metrics
No merged PRs in 30d

Description

At the moment David considers tags, absolute versions (i.e. not semver ranges) and URLs as pinned dependencies. The idea being that the author wants to use a specific version because higher versions don't contain the same functionality (the author doesn't have a choice not to use the dependency at that version) or because it is a custom build of the module (for a URL dependency) or for some other reason. Pinned dependencies don't normally count towards your David badge, but when an author has pinned _all_ dependencies to specific versions the reasoning behind not counting pinned dependencies towards your badge is incorrect, since if all dependencies are pinned the badge will _always_ be green.

I propose that when _all_ dependencies are pinned, absolute versions _should_ affect the David badge colour.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.