akveo / akveo/ng2-smart-table

colspan for noDataFound case is not calculated properly with custom action

Open
#629 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.6k
Forks
867
PR merge metrics
No merged PRs in 30d

Description

When action's add, edit, delete are all set to false and action's custom is added, empty table does not set colspan property properly (colspan value is one less than it's supposed to be). I have a solution here below.

https://github.com/akveo/ng2-smart-table/blob/8f37d374a87a9008328aaea36ad6ce78a28ce7a8/src/ng2-smart-table/components/tbody/tbody.component.ts#L50

```
this.isActionDelete = this.grid.getSetting('actions.delete');
+ this.isActionCustom = !!this.grid.getSetting('actions.custom');
```

https://github.com/akveo/ng2-smart-table/blob/8f37d374a87a9008328aaea36ad6ce78a28ce7a8/src/ng2-smart-table/components/tbody/tbody.component.html#L53

```
-
+
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.